-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash on opening from suspend state #6764
Merged
pascalkuthe
merged 5 commits into
helix-editor:master
from
h1t:fix_crash_on_opening_from_suspend_state
Apr 16, 2023
Merged
Fix crash on opening from suspend state #6764
pascalkuthe
merged 5 commits into
helix-editor:master
from
h1t:fix_crash_on_opening_from_suspend_state
Apr 16, 2023
+11
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kareigu
reviewed
Apr 15, 2023
pascalkuthe
reviewed
Apr 15, 2023
also shouldn't we still panic if |
…terminal raw mode
pascalkuthe
previously approved these changes
Apr 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
maxchisto
reviewed
Apr 16, 2023
the-mikedavis
changed the title
Fix crash on opening from suspend state (#6725)
Fix crash on opening from suspend state
Apr 16, 2023
the-mikedavis
approved these changes
Apr 16, 2023
pascalkuthe
approved these changes
Apr 16, 2023
Triton171
pushed a commit
to Triton171/helix
that referenced
this pull request
Jun 18, 2023
* Fix crash on opening from suspend state (helix-editor#6725) * Fix code style * revert using of the imperative code style. Add panic if couldn't set terminal raw mode * remove redundant import of core::panic macros * small refactoring
wes-adams
pushed a commit
to wes-adams/helix
that referenced
this pull request
Jul 4, 2023
* Fix crash on opening from suspend state (helix-editor#6725) * Fix code style * revert using of the imperative code style. Add panic if couldn't set terminal raw mode * remove redundant import of core::panic macros * small refactoring
smortime
pushed a commit
to smortime/helix
that referenced
this pull request
Jul 10, 2024
* Fix crash on opening from suspend state (helix-editor#6725) * Fix code style * revert using of the imperative code style. Add panic if couldn't set terminal raw mode * remove redundant import of core::panic macros * small refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6725
This commit is copy/paste from same issue of neovim: